Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Exclude deleted sites from getBlogs #833

Merged
crazytonyli merged 2 commits into from
Mar 19, 2025
Merged

Exclude deleted sites from getBlogs #833

crazytonyli merged 2 commits into from
Mar 19, 2025

Conversation

@crazytonyli
Copy link
Contributor

@crazytonyli crazytonyli commented Mar 18, 2025 •
edited
Loading

Description

WordPressKit.zip

Relates to wordpress-mobile/WordPress-iOS#23344.

We'll exclude deleted sites for now, and can add them back once the app supports them properly.

ℹ Please replace the above with a link to the issue this pull request addresses, as well as a summary of the implementation details.

Testing Details

ℹ Please replace this with a clear and concise description of the steps required to validate this pull request.

  • Please check here if your pull request includes additional test coverage.
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@crazytonyli crazytonyli changed the base branch from trunk to wpios-edition March 18, 2025 01:14
@dangermattic
Copy link
Collaborator

dangermattic commented Mar 18, 2025

1 Warning
⚠️ Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages in Xcode.

Generated by 🚫 Danger

@crazytonyli crazytonyli force-pushed the me-sites-exclude-deleted branch 2 times, most recently from bc9b11c to 5b504d0 Compare March 18, 2025 01:45
@crazytonyli crazytonyli force-pushed the me-sites-exclude-deleted branch from 5b504d0 to baf2f40 Compare March 18, 2025 09:32
@crazytonyli crazytonyli changed the title Me sites exclude deleted Exclude deleted sites from getBlogs Mar 18, 2025
@crazytonyli crazytonyli requested review from kean and pmusolino March 18, 2025 09:34
@crazytonyli crazytonyli marked this pull request as ready for review March 18, 2025 09:34
@crazytonyli crazytonyli mentioned this pull request Mar 18, 2025
Merged
14 tasks
@pmusolino pmusolino self-assigned this Mar 18, 2025
pmusolino
pmusolino approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@pmusolino pmusolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :shipit:

@crazytonyli crazytonyli merged commit 554d3ef into wpios-edition Mar 19, 2025
9 checks passed
@crazytonyli crazytonyli deleted the me-sites-exclude-deleted branch March 19, 2025 00:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kean kean Awaiting requested review from kean

1 more reviewer

@pmusolino pmusolino pmusolino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pmusolino pmusolino

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crazytonyli @dangermattic @pmusolino